Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for cilk_for #305

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Tests for cilk_for #305

merged 2 commits into from
Jan 25, 2025

Conversation

VoxSciurorum
Copy link
Contributor

Give a better error if an iterator type's operator- returns a non-integral type.

Test that the C++20 init-statement of a range for works with cilk_for.

Test behavior of spawn within the control structure of cilk_for.

neboat
neboat reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@neboat neboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good overall. Can you rebase them on dev/19.x?

You might have to update some of the tests after rebasing. Some of the diagnostic messages changed slightly in dev/19.x.

@VoxSciurorum VoxSciurorum changed the base branch from dev/18.x to dev/19.x January 20, 2025 23:28
@neboat
Copy link
Collaborator

neboat commented Jan 25, 2025

I missed that you pushed changes to this PR. Sorry about that.

@neboat neboat merged commit 82324d1 into dev/19.x Jan 25, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neboat neboat neboat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VoxSciurorum @neboat